Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward mode for gregorio-test.sh #346

Open
rpspringuel opened this issue Feb 15, 2021 · 2 comments
Open

Backward mode for gregorio-test.sh #346

rpspringuel opened this issue Feb 15, 2021 · 2 comments

Comments

@rpspringuel
Copy link
Contributor

There should be a backward mode for gregorio-test.sh which will convert given TEST into a backwards compatibility test (copying the files into backwards/ and adding the _B as appropriate).

Further, review-results.sh should have an option where a failed test can be converted to a backwards compatibility test (with the current expectation) and the result (which failed against the old expectation) made into the future expectation for that test.

@henryso
Copy link
Contributor

henryso commented Feb 15, 2021

How is that different than accepting the result as the new expectation for the current test?

@rpspringuel
Copy link
Contributor Author

The issue is when the backwards compatibility test doesn't yet exist. This option would create the backwards/TEST using the existing tests/TEST as the basis (copying all related files and modifying the filenames). One would do this for a test which involves code which has been deprecated. Once the backwards compatibility test is created, you'd then (if needed) modify the tests/TEST to not use the deprecated code and (if that also changes the result) accept the result as the new expectation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants