Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xexpr->string screws up whitespace #75

Open
sorawee opened this issue Nov 8, 2018 · 1 comment · May be fixed by #76
Open

xexpr->string screws up whitespace #75

sorawee opened this issue Nov 8, 2018 · 1 comment · May be fixed by #76

Comments

@sorawee
Copy link

sorawee commented Nov 8, 2018

Consider:

#lang racket

(require (only-in markdown [xexpr->string f1]))
(require (only-in xml [xexpr->string f2]))

(define (xexprs->string f xs)
  (string-join (map f xs) "\n"))

(define data '((p () "Hello" (label) ".")))

(xexprs->string f1 data)
(xexprs->string f2 data)

Here's the result:

"\n<p>Hello\n <label></label>.</p>"
"<p>Hello<label></label>.</p>"

When rendered, xexpr->string from this package will produce an extraneous whitespace which is incorrect. Since Frog uses this function, HTML rendering in Frog is also wrong.
@sorawee
Copy link
Author

sorawee commented Nov 8, 2018

The behavior seems to be intentional (

markdown/markdown/display-xexpr.rkt

Line 36 in 7ee72b1

(when (and (zero? pre)
), but it's wrong. If I write

a<label></label>b

a and b should not be separated by a whitespace

@sorawee sorawee linked a pull request Nov 8, 2018 that will close this issue
Open
@sorawee sorawee mentioned this issue Feb 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add all inline elements to avoid wrong space breaking sorawee/markdown
1 participant
@sorawee