From 87cfb76878f22fe663a3b20697c15adface3fda8 Mon Sep 17 00:00:00 2001 From: Sergei Antipov Date: Thu, 27 Aug 2020 17:19:46 -0400 Subject: [PATCH] Do not set priorityClassName for hooks (#2066) Reverting previous changes for hooks. cluster-critical priority could be set only for kube-system resources and this could break existing pre-update hooks for applications. --- lib/app/hooks/configure.go | 5 ----- lib/defaults/defaults.go | 3 --- 2 files changed, 8 deletions(-) diff --git a/lib/app/hooks/configure.go b/lib/app/hooks/configure.go index 015e896fbd..b44833587c 100644 --- a/lib/app/hooks/configure.go +++ b/lib/app/hooks/configure.go @@ -129,11 +129,6 @@ func configureMetadata(job *batchv1.Job, p Params) error { job.Spec.Template.Spec.SecurityContext = defaults.HookSecurityContext() } - // if priorityClassName is not specified, set the default one - if job.Spec.Template.Spec.PriorityClassName == "" { - job.Spec.Template.Spec.PriorityClassName = defaults.HookPriorityClassName - } - return nil } diff --git a/lib/defaults/defaults.go b/lib/defaults/defaults.go index a159eb5606..a203c44eff 100644 --- a/lib/defaults/defaults.go +++ b/lib/defaults/defaults.go @@ -1182,9 +1182,6 @@ const ( // GravityFileLabel specifies the file label for the gravity binary GravityFileLabel = "system_u:object_r:gravity_exec_t:s0" - - // HookPriorityClassName specifies the default priority class for hooks - HookPriorityClassName = "system-cluster-critical" ) var (