Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back import "foo.yaml" #177

Closed
sh0rez opened this issue Jan 21, 2020 · 4 comments
Closed

Bring back import "foo.yaml" #177

sh0rez opened this issue Jan 21, 2020 · 4 comments
Assignees
Labels
component/jsonnet Everything regarding the jsonnet language keepalive kind/enhancement Improve something existing lifecycle/blocked Blocked by outstanding changes (to another project)

Comments

@sh0rez
Copy link
Member

sh0rez commented Jan 21, 2020

We had to disable this in #176, because of #135.

Bringing this back requires upstream changes to Jsonnet: #135 (comment)

@sh0rez sh0rez added component/jsonnet Everything regarding the jsonnet language kind/enhancement Improve something existing lifecycle/blocked Blocked by outstanding changes (to another project) labels Jan 21, 2020
@sh0rez sh0rez self-assigned this Jan 21, 2020
@stale
Copy link

stale bot commented Feb 20, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@sh0rez
Copy link
Member Author

sh0rez commented Jan 8, 2021

@sbarzowski do you see any chance a change to go-jsonnet could make that possible? Otherwise I will close this issue

@sbarzowski
Copy link

Not anytime soon. There's a lot of lower hanging fruit. For now we'll need to live with parseYaml(importstr 'foo.yaml'). And if/when we introduce upstream support it will probably require little or no change here.

I've opened an issue on Jsonnet side to track this idea (google/jsonnet#878). We can close it here, I think.

@sh0rez
Copy link
Member Author

sh0rez commented Jan 8, 2021

Sounds good to me! Let me know if I can help!

@sh0rez sh0rez closed this as completed Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/jsonnet Everything regarding the jsonnet language keepalive kind/enhancement Improve something existing lifecycle/blocked Blocked by outstanding changes (to another project)
Projects
None yet
Development

No branches or pull requests

2 participants