From d056daa58d4cc705167fb9f4e758b3f1e221bf9f Mon Sep 17 00:00:00 2001 From: Vladimir Varankin Date: Wed, 2 Oct 2024 15:09:08 +0200 Subject: [PATCH 1/2] ingester: comment on experimental status of owned series limits Signed-off-by: Vladimir Varankin --- pkg/ingester/ingester.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pkg/ingester/ingester.go b/pkg/ingester/ingester.go index e4a5915b40..9c1ab24b64 100644 --- a/pkg/ingester/ingester.go +++ b/pkg/ingester/ingester.go @@ -202,6 +202,8 @@ type Config struct { ErrorSampleRate int64 `yaml:"error_sample_rate" json:"error_sample_rate" category:"advanced"` + // use-ingester-owned-series-for-limits was added in 2.12, but we keep it experimental until we decide, what is the correct behaviour + // when the replication factor and the number of zones don't match. Refer to notes in https://github.com/grafana/mimir/pull/8695 and https://github.com/grafana/mimir/pull/9496 UseIngesterOwnedSeriesForLimits bool `yaml:"use_ingester_owned_series_for_limits" category:"experimental"` UpdateIngesterOwnedSeries bool `yaml:"track_ingester_owned_series" category:"experimental"` OwnedSeriesUpdateInterval time.Duration `yaml:"owned_series_update_interval" category:"experimental"` From 31bb78b7dd5763560108b2821a7132700d130cb9 Mon Sep 17 00:00:00 2001 From: Vladimir Varankin Date: Thu, 3 Oct 2024 13:19:28 +0200 Subject: [PATCH 2/2] Update pkg/ingester/ingester.go Co-authored-by: Dimitar Dimitrov --- pkg/ingester/ingester.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/ingester/ingester.go b/pkg/ingester/ingester.go index 9c1ab24b64..b636319723 100644 --- a/pkg/ingester/ingester.go +++ b/pkg/ingester/ingester.go @@ -202,7 +202,7 @@ type Config struct { ErrorSampleRate int64 `yaml:"error_sample_rate" json:"error_sample_rate" category:"advanced"` - // use-ingester-owned-series-for-limits was added in 2.12, but we keep it experimental until we decide, what is the correct behaviour + // UseIngesterOwnedSeriesForLimits was added in 2.12, but we keep it experimental until we decide, what is the correct behaviour // when the replication factor and the number of zones don't match. Refer to notes in https://github.com/grafana/mimir/pull/8695 and https://github.com/grafana/mimir/pull/9496 UseIngesterOwnedSeriesForLimits bool `yaml:"use_ingester_owned_series_for_limits" category:"experimental"` UpdateIngesterOwnedSeries bool `yaml:"track_ingester_owned_series" category:"experimental"`