-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruler] Support external labels #3490
Comments
👋
Could you share more about your use case, please? Why would you want to set, for example, "cluster" on the ruler series? Mimir typically is deployed as a centralised metrics database, collecting metrics from multiple clusters, so the "cluster" label is expected to be set in ingested metrics (received from Prometheus or the Agent) and then the ruler just use it. My previous question follows the "cluster" example you made, but generally speaking we haven't seen the need of having external labels support in the Mimir ruler so far, so I would like to better understand your use case. Thanks! |
Hi! @bilbof has not answered but I will share our use case: We have a single dashboard setup as a receiver of all our alertmanager in different environments (testing, staging, production, etc). We rely on external labels sent by prometheus to alertmanager to separate and categorize alerts automatically in the dashboard. Without that, all alerts are grouped together as if they originated from the same environment EDIT: We 'fixed' it by using |
A similar use cas I have that could benefit from having external labels set bu Mimir Ruler: I am using Sloth to produce PrometheusRules resources which are then loaded into Mimir Ruler via Grafana Agent mimir.rules.kubernetes. The problem then is that I am relying on a label
|
We have the same problem and the issue is that with prometheus we crafted a lot of alerts using aggregations (like sum by) and used external labels to add those labels in alertmanager but with Mimir, we would need to add those labels to all by clauses of all alerts which makes them then really hard to read when you have more than just 1 external label |
We need to pick up that PR, adding some tests and fixing nits. This can be done by origin author or someone else who is willing to contribute. |
Hey @pracucci, sorry for the delayed response. I'm no longer working on that project, but IIRC the use case is:
If you want to give a dedicated instance of Mimir to a team/department/cluster/environment, and aggregate alerts, then |
Is your feature request related to a problem? Please describe.
It's not possible to set extra labels on series at the ruler, like it is with Prometheus with
external_labels
. So you can't set e.g. 'cluster' or 'environment' etc.Describe the solution you'd like
Something like what Prometheus provides:
The text was updated successfully, but these errors were encountered: