From a5783ae9074ca1610e9ef9c77d4303e17c2a1d59 Mon Sep 17 00:00:00 2001 From: Arve Knudsen Date: Fri, 13 Dec 2024 07:45:19 +0100 Subject: [PATCH] Always free buffers Signed-off-by: Arve Knudsen --- pkg/distributor/query.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/distributor/query.go b/pkg/distributor/query.go index ff1483a63e..75801a4d75 100644 --- a/pkg/distributor/query.go +++ b/pkg/distributor/query.go @@ -266,9 +266,7 @@ func (d *Distributor) queryIngesterStream(ctx context.Context, replicationSets [ cleanup() } - if err != nil { - result.freeBuffers() - } + result.freeBuffers() }() log.Span.SetTag("ingester_address", ing.Addr) @@ -458,7 +456,7 @@ func (d *Distributor) queryIngesterStream(ctx context.Context, replicationSets [ res.streamingSeries.StreamReader.StartBuffering() } - res.freeBuffers() + // res.freeBuffers() } // Now turn the accumulated maps into slices.