From 904e1ce586d92ede00b6cb79f0012ea8a31dc12d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Peter=20=C5=A0tibran=C3=BD?= Date: Wed, 20 Mar 2024 15:37:22 +0100 Subject: [PATCH] Enhance description of failed reads. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Peter Štibraný --- operations/mimir-mixin/dashboards/queries.libsonnet | 4 ++-- operations/mimir-mixin/dashboards/writes.libsonnet | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/operations/mimir-mixin/dashboards/queries.libsonnet b/operations/mimir-mixin/dashboards/queries.libsonnet index 3511dba5cf8..09fe948a578 100644 --- a/operations/mimir-mixin/dashboards/queries.libsonnet +++ b/operations/mimir-mixin/dashboards/queries.libsonnet @@ -231,9 +231,9 @@ local filename = 'mimir-queries.json'; + $.stack ) .addPanel( - $.timeseriesPanel('Strong consistency – wait latency') + + $.timeseriesPanel('Strong consistency queries — wait latency') + $.panelDescription( - 'Strong consistency – Wait latency', + 'Strong consistency queries — wait latency', ||| How long does the request wait to guarantee strong consistency. ||| diff --git a/operations/mimir-mixin/dashboards/writes.libsonnet b/operations/mimir-mixin/dashboards/writes.libsonnet index 0042d83de0c..fae071cefb4 100644 --- a/operations/mimir-mixin/dashboards/writes.libsonnet +++ b/operations/mimir-mixin/dashboards/writes.libsonnet @@ -245,6 +245,7 @@ local filename = 'mimir-writes.json'; 'Kafka fetches / sec', ||| Rate of fetches received from Kafka brokers. A fetch can contain multiple records (a write request received on the write path is mapped into a single record). + Read errors are any errors reported on connection to Kafka brokers, and are separate from "failed" fetches. ||| ) + $.queryPanel( @@ -263,7 +264,7 @@ local filename = 'mimir-writes.json'; 'failed', 'read errors', ], - ) + $.aliasColors({ failed: $._colors.failed, 'read errors': $._colors.failed }) + $.stack, + ) + $.aliasColors({ successful: $._colors.success, failed: $._colors.failed, 'read errors': $._colors.failed }) + $.stack, ) .addPanel( $.timeseriesPanel('Kafka records / sec') +