Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup experimental/streams and experimental/fs after #4017 #4018

Open
mstoykov opened this issue Oct 25, 2024 · 0 comments
Open

Cleanup experimental/streams and experimental/fs after #4017 #4018

mstoykov opened this issue Oct 25, 2024 · 0 comments
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor

Comments

@mstoykov
Copy link
Contributor

Problem:

Experimental/streams uses a lot of promises and during #4017 it seemed way nicer to return errors upwards in most cases, but instead I had to panic or rewrite big parts of the module.

As such I choose to get the change out especially as experimental/streams is currently fairly lightly used. Similar is the situation with experimental/fs but to a lesser degree.

Solution:

It will be nice if both modules propagate errors upwards and let Sobek handle it.

As well as having tests that this work well with the interrupt - which will likely require quite a lot of tests.

@mstoykov mstoykov added evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor labels Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
evaluation needed proposal needs to be validated or tested before fully implementing it in k6 refactor
Projects
None yet
Development

No branches or pull requests

1 participant