Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

managed-by is set at install time by the managing installer, and should not be templated. #3394

Open
bleggett opened this issue Nov 4, 2024 · 0 comments

Comments

@bleggett
Copy link
Contributor

bleggett commented Nov 4, 2024

app.kubernetes.io/managed-by: Helm is automatically applied to resources installed by Helm via helm install, and does not need to be (read: should not be) manually templated. The label is an install-time label that should be applied by the tool actually installing the resources into the cluster.

This matters because helm template should (and by default will) produce YAML without this label, as it is unknown at template-time what will "manage" the resource - e.g. helm template | kubectl apply -f - should not produce resources with the app.kubernetes.io/managed-by: Helm label, because the resources are not managed by helm.

xref: istio/istio#53698

and: #3389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant