Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apt packages have Origin "grafana stable" and Suite "stable" #45242

Closed
caugner opened this issue Feb 10, 2022 · 6 comments
Closed

apt packages have Origin "grafana stable" and Suite "stable" #45242

caugner opened this issue Feb 10, 2022 · 6 comments
Labels
stale Issue with no recent activity type/build-packaging

Comments

@caugner
Copy link

caugner commented Feb 10, 2022

What happened:

In order to have unattended-ugprades upgrade grafana automatically on Ubuntu 20.04 LTS (focal), I had to add the following line to the /etc/apt/apt.conf.d/50unattended-upgrades config:

Unattended-Upgrade::Allowed-Origins {
        "${distro_id}:${distro_codename}";
        "${distro_id}:${distro_codename}-security";
        // Extended Security Maintenance; doesn't necessarily exist for
        // every release and this system may not have it installed, but if
        // available, the policy for updates is such that unattended-upgrades
        // should also install from here by default.
        "${distro_id}ESMApps:${distro_codename}-apps-security";
        "${distro_id}ESM:${distro_codename}-infra-security";
//      "${distro_id}:${distro_codename}-updates";
//      "${distro_id}:${distro_codename}-proposed";
//      "${distro_id}:${distro_codename}-backports";
        "grafana stable:stable"; // Added.
};

This is due to the fact that the apt packages have the following Origin and Suite:

# grep -P "Origin|Suite" /var/lib/apt/lists/packages.grafana.com_oss_deb_dists_stable_InRelease
Origin: grafana stable
Suite: stable

What you expected to happen:

Afaik the Origin would usually just be grafana and the Suite would be focal (${distro_codename}).

How to reproduce it (as minimally and precisely as possible):

Add "grafana:${distro_codename}"; instead and unattended-upgrades won't upgrade grafana.

Anything else we need to know?:

Environment:

  • Grafana version: 8.3.4 -> 8.3.6
  • Data source type & version: n/a
  • OS Grafana is installed on: Ubuntu 20.04.3 LTS
  • User OS & Browser: n/a
  • Grafana plugins: n/a
  • Others: n/a

I suggested a similar change over at mattermost/mattermost-omnibus#58.

@tleopold
Copy link

@julienduchesne Do you have any updates on this issue?

@julienduchesne
Copy link
Member

My initial guess is that it's probably too late to fix this once the repository has been initially created

@caugner
Copy link
Author

caugner commented Nov 17, 2022

My initial guess is that it's probably too late to fix this once the repository has been initially created

Afaik you specify the Origin/Suite for each release, so fixing it for upcoming releases is indeed possible.

@summerwollin summerwollin added the stale Issue with no recent activity label Dec 20, 2023
@summerwollin
Copy link
Contributor

Closing as this is stale

@nevart
Copy link

nevart commented Dec 20, 2023

That's not really stale, is it? It was just not taken care of, but the problem still exists.

@caugner
Copy link
Author

caugner commented Dec 21, 2023

@summerwollin Did you intend to close this as wontfix? IIRC This issue prevents admins from upgrading their Grafana instances with unattended upgrades.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Issue with no recent activity type/build-packaging
Projects
None yet
Development

No branches or pull requests

6 participants