-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix span name for HTTPClient calls #1244
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1244 +/- ##
===========================================
- Coverage 78.35% 34.10% -44.25%
===========================================
Files 145 142 -3
Lines 14639 14560 -79
===========================================
- Hits 11470 4966 -6504
- Misses 2570 9152 +6582
+ Partials 599 442 -157
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I guess we may need to adjust bunch of tests for this to pass.
test/integration/traces_test.go
Outdated
@@ -752,7 +752,7 @@ func testNestedHTTPTracesKProbes(t *testing.T) { | |||
|
|||
// Check the information of the java parent span | |||
res = trace.FindByOperationName("GET /jtrace") | |||
require.Len(t, res, 1) | |||
require.Len(t, res, 2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right, I guess now multiple spans will match with the same URL path. I think we need to extend FindOperationByName to use an optional parameter which is the span kind and look for the server span. Otherwise many other tests will have an issue.
We are generating metrics like:
missing the route information in span name. This PR fixes this issue