Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded checksums follow-up #178

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Hardcoded checksums follow-up #178

merged 1 commit into from
Feb 7, 2024

Conversation

Marcono1234
Copy link
Contributor

@Marcono1234 Marcono1234 commented Feb 3, 2024 •
edited
Loading

Follow-up for the review feedback on #167

  • Added bot/ prefix to branch name of automatically generated pull request
  • Added tests verifying that KNOWN_VALID_CHECKSUMS is not empty

@Marcono1234 Marcono1234 mentioned this pull request Feb 3, 2024
Closed
JLLeitschuh
JLLeitschuh approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@JLLeitschuh JLLeitschuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thank you so much for this!

@bigdaz bigdaz merged commit ac96f18 into gradle:main Feb 7, 2024
5 checks passed
@Marcono1234 Marcono1234 deleted the hardcoded-checksums-followup branch February 7, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLLeitschuh JLLeitschuh JLLeitschuh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marcono1234 @JLLeitschuh @bigdaz