-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade scala/zinc to 1.10.4 #30892
Open
tnielens
wants to merge
3
commits into
gradle:master
Choose a base branch
from
tnielens:upgrade-zinc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
upgrade scala/zinc to 1.10.4 #30892
+136
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnielens
force-pushed
the
upgrade-zinc
branch
from
October 13, 2024 19:45
fe207e5
to
f0b7339
Compare
A test case failure seems to indicate a regression with the zinc upgrade. I'm having a look. |
tnielens
force-pushed
the
upgrade-zinc
branch
from
October 13, 2024 21:42
f0b7339
to
8a3f014
Compare
This comment has been minimized.
This comment has been minimized.
I've triggered the following builds: |
The following builds have failed: |
@bot-gradle test this please |
This comment has been minimized.
This comment has been minimized.
The following builds have failed: |
Signed-off-by: Tim Nielens <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades zinc, the scala incremental compiler, to 1.10.2.
Context
Includes compiler avoidance bug fix sbt/zinc#1382 which affects gradle multi project builds.
Contributor Checklist
<subproject>/src/integTest
) to verify changes from a user perspective.<subproject>/src/test
) to verify logic../gradlew sanityCheck
../gradlew <changed-subproject>:quickTest
.Reviewing cheatsheet
Before merging the PR, comments starting with