Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bulid-scan-link capture #1

Merged
merged 3 commits into from
May 17, 2024
Merged

Enable bulid-scan-link capture #1

merged 3 commits into from
May 17, 2024

Conversation

bigdaz
Copy link
Member

@bigdaz bigdaz commented May 16, 2024

If a consumer adds a captureBuildScanLink method implementation to the init-script,
this method will be notified with links for all build scans published by the build.

@bigdaz bigdaz requested a review from alextu May 16, 2024 18:28
If a consumer adds a `captureBuildScanLink` method implementation to the init-script,
this method will be notified with links for all build scans published by the build.
In order to be configuration-cache compatible, the build-scan capture logic
must be enclosed in a class.
Copy link
Member

@alextu alextu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that we have this coverage now

@bigdaz bigdaz merged commit 5c07403 into main May 17, 2024
1 check passed
@bigdaz bigdaz deleted the dd/build-results-capture branch May 17, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants