Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in Custom Values Reporting between Jenkins and GitHub Actions #203

Open
bachiri opened this issue Jul 19, 2023 · 1 comment

Comments

@bachiri
Copy link

bachiri commented Jul 19, 2023

Hi 👋

We are currently migrating from Jenkins to GHA, and by comparing the scans produced by this plugin and we think it's not supporting correctly Github Actions.

We have observed some inconsistencies on its custom values as you can see below .
image

The main problems are :

  • Git branch is reported always as HEAD, when we'd expect to have the git branch name
  • The git commit on PRs is reporting the virtual merge commit instead of the HEAD commit of the PR (this also was happening on jenkins)
  • We don't see the PR number in any custom value.

Proposal Fixes :

Follow the same pattern applied in getGitBranchName function, and use CI environment variables to report git branch / commit / PR number / repository and fall back to the git command when it can't be read from it.

We'll only add the logic for GHA, but anyone else can support other CIs later.

@runningcode
Copy link
Contributor

runningcode commented Jul 20, 2023

Thanks for reporting this! We'll have a look.

As far as we understand though, there is no simple way to get the PR number from a GHA build. If you find a way, please let us know

Related to #74

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants