Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inline forms not working after django 4.1 #205

Open
guilleijo opened this issue Feb 10, 2023 · 3 comments · May be fixed by #204
Open

Inline forms not working after django 4.1 #205

guilleijo opened this issue Feb 10, 2023 · 3 comments · May be fixed by #204

Comments

@guilleijo
Copy link

guilleijo commented Feb 10, 2023 •
edited
Loading

  • Django better admin ArrayField version: 1.4.2
  • Django version: 4.1.4
  • Python version: 3.11
  • Operating System: macOS 12.6 (Monterey)

Description

When using a better array field in an inline admin the Add another button does not work on new items. The Uncaught TypeError: Cannot read properties of undefined (reading '0') error is seen in the console when adding a new inline item.

This is caused by changes in django 4.1. From the docs:

Changed in Django 4.1:
In older versions, the event was a jQuery event with $row and formsetName parameters.
It is now a JavaScript CustomEvent with parameters set in event.detail.

Possibly related to some of the issues people are having described in issue #25
@guilleijo guilleijo linked a pull request Feb 10, 2023 that will close this issue
Open
@ahadihadi
Copy link

in my case adding extra = 1 (or 2... not zero) to TabularInline class solved the issue. when the value of extra is zero issue comes back

@lopster624
Copy link

lopster624 commented Oct 24, 2024 •
edited
Loading

in my case adding extra = 1 (or 2... not zero) to TabularInline class solved the issue. when the value of extra is zero issue comes back

that solution works only for the first new item. if you will add another one - button won't work

@guilleijo
Copy link
Author

I created a PR with the fix here, but I don't think that it will be merged. Sadly, looks like this is not maintained anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix inline forms for django 4.1+ guilleijo/django-better-admin-arrayfield
3 participants
@guilleijo @lopster624 @ahadihadi