Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate header and extend collections. #3

Open
SGSSGene opened this issue Jan 15, 2020 · 0 comments
Open

Separate header and extend collections. #3

SGSSGene opened this issue Jan 15, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@SGSSGene
Copy link
Member

SGSSGene commented Jan 15, 2020

sargparse implements an incomplete is_collection trait.
Currently it is only applied to std::vector and std::set.

I suggest to extend this to more types like std::list, std::unordered_set and maybe more?!

Also I would suggest to introduce a header for each trait. Otherwise it is necessary to include all the StandardLib headers my default which is not wanted.

Second this could also be used to introduce a general "sargparse.h" header.

Code could look than like this:

#include <sargparse/sargparse.h>
#include <sargparse/vector.h>
@SGSSGene SGSSGene added the bug Something isn't working label Jan 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant