Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clippy more strict #752

Open
jaytaph opened this issue Jan 1, 2025 · 0 comments
Open

Make clippy more strict #752

jaytaph opened this issue Jan 1, 2025 · 0 comments

Comments

@jaytaph
Copy link
Member

jaytaph commented Jan 1, 2025

Right now we have a very open clippy policy (the default basically).. We probably want to have a more strict setting of clippy rules.

An initial idea was:

[workspace.lints.clippy]
#perf = { level = "deny", priority = -1 }
#pedantic = { level = "warn", priority = -1 }
#nursery = { level = "warn", priority = -1 }
#cargo = { level = "warn", priority = -1 }
#panic = "deny"
#unwrap_used = "deny"
clone_on_ref_ptr = "warn"
empty_enum_variants_with_brackets = "warn"
empty_structs_with_brackets = "warn"
enum_glob_use = "warn"
error_impl_error = "warn"
format_push_string = "warn"
infinite_loop = "warn"
rc_buffer = "warn"
rc_mutex = "warn"
expect_used = "warn"
missing_docs_in_private_items = "allow"
cargo_common_metadata = "allow" # should be removed if we release our crates to crates.io
cast_possible_truncation = "allow" # should this be on allow?
cast_precision_loss = "allow"
cast_sign_loss = "allow"
cast_possible_wrap = "allow"
or_fun_call = "allow"
multiple_crate_versions = "allow" # should this be on allow?
missing_errors_doc = "allow"
cognitive_complexity = "allow"
float_cmp = "allow" #TODO: this should be changed and f32/f64::EPSILON should be used
doc_markdown = "allow"
too_many_lines = "allow"

but there might be better ones we can use.

Also, we need to investigate how many issues this will result into, and how much effort it might take to do a cleanup of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant