Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Web Scripting: Rework gosub_webexecutor so the current trait are not js-bound #746

Open
Sharktheone opened this issue Dec 30, 2024 · 0 comments
Open

Web Scripting: Rework gosub_webexecutor so the current trait are not js-bound #746

Sharktheone opened this issue Dec 30, 2024 · 0 comments
Labels
javascript api Any issues related to our API interaction with the javascript engine javascript Any issues related to JavaScript

Comments

@Sharktheone
Copy link
Member

Sharktheone commented Dec 30, 2024 •
edited
Loading

Currently, all traits defined in the gosub_webexecutor are JSSomething, even tough they probably can be used also used for other languages like Lua.
So we need to try to make them less specific about JS and also remove the JS prefix in all of them.

It also needs to handle the creation of the prototypes. Currently, everything just gets put on the real Object, which is correct in some cases, but often not what we want.
@Sharktheone Sharktheone added javascript Any issues related to JavaScript javascript api Any issues related to our API interaction with the javascript engine labels Dec 30, 2024
@Sharktheone Sharktheone moved this to 📝 Todo in Gosub Engine Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
javascript api Any issues related to our API interaction with the javascript engine javascript Any issues related to JavaScript
Projects
Gosub Engine
Status: 📝 Todo
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Sharktheone