Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader uniform naming should be handled better #6

Open
bil-bas opened this issue Aug 12, 2012 · 0 comments
Open

Shader uniform naming should be handled better #6

bil-bas opened this issue Aug 12, 2012 · 0 comments
Assignees
Milestone

Comments

@bil-bas
Copy link
Collaborator

bil-bas commented Aug 12, 2012

At the moment, a uniform can be accessed as "in_VarName" or :var_name (used, in Shader#initialize, for example). Alternatively one can call (dynamic) methods to set them, such as shader.var_name = 5

Definitely shouldn't be treating strings and symbols differently, because that will confuse people who think they are the same thing :D

Either should enforce a naming convention or allow anyone to use whatever, but the latter would mean you'd be doing shader.in_VarName if you wanted to be consistent with a common GLSL standard. Meh, all messy!

@ghost ghost assigned bil-bas Aug 12, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant