From 22d547bbf61372a5ac120fcf057a65b436c51887 Mon Sep 17 00:00:00 2001 From: etowahadams Date: Mon, 10 Jun 2024 12:03:05 -0400 Subject: [PATCH 1/2] feat: remove specProcessed event --- src/compiler/compile.ts | 8 -------- src/gosling-schema/gosling.schema.ts | 1 - 2 files changed, 9 deletions(-) diff --git a/src/compiler/compile.ts b/src/compiler/compile.ts index b2381e8c..45b46ab0 100644 --- a/src/compiler/compile.ts +++ b/src/compiler/compile.ts @@ -8,7 +8,6 @@ import type { UrlToFetchOptions } from 'src/core/gosling-component'; import { renderHiGlass as createHiGlassModels } from './create-higlass-models'; import { manageResponsiveSpecs } from './responsive'; import type { IdTable } from '../api/track-and-view-ids'; -import { publish } from '../api/pubsub'; /** The callback function called everytime after the spec has been compiled */ export type CompileCallback = ( @@ -70,13 +69,6 @@ export function compile( trackInfos = getRelativeTrackInfo(specCopy, theme).trackInfos; } - // publish the fixed spec - // used for alt-gosling - publish('specProcessed', { - id: specCopy.id, - spec: specCopy - }); - // Make HiGlass models for individual tracks createHiGlassModels(specCopy, trackInfos, callback, theme, urlToFetchOptions); } diff --git a/src/gosling-schema/gosling.schema.ts b/src/gosling-schema/gosling.schema.ts index d36ff29b..755c85e7 100644 --- a/src/gosling-schema/gosling.schema.ts +++ b/src/gosling-schema/gosling.schema.ts @@ -379,7 +379,6 @@ export type _EventMap = { click: PointMouseEventData; rangeSelect: RangeMouseEventData; rawData: CommonEventData; - specProcessed: SpecEventData; trackMouseOver: TrackApiData; trackClick: TrackApiData; // TODO (Jul-25-2022): with https://github.com/higlass/higlass/pull/1098, we can support circular layouts onNewTrack: OnNewTrackEventData; From f3f8ec7cc6e8eb64a3e797f875bb28c448854dce Mon Sep 17 00:00:00 2001 From: etowahadams Date: Mon, 10 Jun 2024 12:03:37 -0400 Subject: [PATCH 2/2] feat: update schema --- src/gosling-schema/gosling.schema.ts | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/gosling-schema/gosling.schema.ts b/src/gosling-schema/gosling.schema.ts index 755c85e7..27d5e531 100644 --- a/src/gosling-schema/gosling.schema.ts +++ b/src/gosling-schema/gosling.schema.ts @@ -284,13 +284,6 @@ interface CommonEventData { data: Datum[]; } -interface SpecEventData { - /** Source visualization ID, i.e., `track.id` */ - id: string; - /** Gosling spec */ - spec: GoslingSpec; -} - export interface GenomicPosition { chromosome: string; position: number;