From cf6cbc5caf0561461401b11bad7b211c85c0be06 Mon Sep 17 00:00:00 2001 From: Randall Keur Date: Mon, 18 Nov 2024 10:19:20 -0500 Subject: [PATCH] add Adrian as codeowner so it can be him or core-enablement team to approve PRs and updates to testing --- .github/CODEOWNERS | 3 ++- .github/workflows/sdk_validation.yaml | 24 +++++------------------- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index efb61af..75aedb4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1 +1,2 @@ -* @goshippo/core-enablement \ No newline at end of file +* @goshippo/core-enablement +* @AdrianCollinsShippo \ No newline at end of file diff --git a/.github/workflows/sdk_validation.yaml b/.github/workflows/sdk_validation.yaml index 477e22a..4d49bd0 100644 --- a/.github/workflows/sdk_validation.yaml +++ b/.github/workflows/sdk_validation.yaml @@ -1,4 +1,5 @@ name: Validate + permissions: contents: write id-token: write @@ -17,23 +18,8 @@ jobs: runs-on: ubuntu-latest timeout-minutes: 10 concurrency: - group: php-sdk-check + group: php-sdk-check-${{ github.event.pull_request.number }} steps: - - name: Authenticate with AWS - uses: goshippo/shippo-action-workflows/.github/actions/aws_auth@v1.1.0 - with: - environment: dev-main - oidc-name: shippo-php-sdk-pipeline - login-to-ecr: false - - - name: Get Speakeasy Secrets Manager - uses: aws-actions/aws-secretsmanager-get-secrets@v2 - with: - secret-ids: | - dev-main-speakeasy-api-key - name-transformation: uppercase - parse-json-secrets: true - - name: Check out repository uses: actions/checkout@v4 @@ -41,7 +27,7 @@ jobs: id: setup_php uses: shivammathur/setup-php@v2 with: - php-version: '8.1' + php-version: '8.2' - name: cache dependencies uses: actions/cache@v4 @@ -54,6 +40,6 @@ jobs: make install - name: Check - run: make check + run: make check env: - SHIPPO_TOKEN: ${{ env.DEV_MAIN_SPEAKEASY_API_KEY_SHIPPO_TOKEN }} + SHIPPO_TOKEN: ${{ secrets.SHIPPO_TOKEN }}