-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Shutdown to support graceful quit of HTTP Server #98
Conversation
Important Review skippedAuto reviews are limited to specific labels. Labels to auto review (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR 👍
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1.2.x #98 +/- ##
=========================================
Coverage ? 78.91%
=========================================
Files ? 12
Lines ? 849
Branches ? 0
=========================================
Hits ? 670
Misses ? 152
Partials ? 27 ☔ View full report in Codecov by Sentry. |
* feat: add Shutdown to support graceful quit of HTTP Server (#98) * add Shutdown to support graceful quit of HTTP Server * improve unit testing --------- Co-authored-by: 朱祥东 <[email protected]> * feat: Optmize Shutdown (#99) * refactor: change `WithValue` key type to any (#103) * bump ver goravel framework * ref: use any as the key type for WithValue * test: more test cases for WithValue and Context * test: swap the expected and actual value in assertion * test: remove type assert * upgrade: v1.2.4 (#104) * update workflows --------- Co-authored-by: zxdstyle <[email protected]> Co-authored-by: 朱祥东 <[email protected]> Co-authored-by: Danial <[email protected]>
📑 Description
Closes https://github.com/goravel/goravel/issues/?
@coderabbitai summary
✅ Checks