Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: The HTTP module supports set Cookie #49

Merged
merged 7 commits into from
Dec 16, 2023
Merged

feat: The HTTP module supports set Cookie #49

merged 7 commits into from
Dec 16, 2023
+235 −119

Conversation

kkumar-gcc
Copy link
Member

Closes #

📑 Description

✅ Checks

  • My pull request adheres to the code style of this project
  • My code requires changes to the documentation
  • I have updated the documentation as required
  • All the tests have passed

ℹ Additional Information

@kkumar-gcc kkumar-gcc requested a review from a team December 14, 2023 10:22
@devhaozi
Copy link
Member

@kkumar-gcc tests failed

@kkumar-gcc kkumar-gcc requested a review from devhaozi December 14, 2023 15:17
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c88085d) 77.99% compared to head (b7ab755) 78.56%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #49      +/-   ##
==========================================
+ Coverage   77.99%   78.56%   +0.56%     
==========================================
  Files          10       10              
  Lines         868      891      +23     
==========================================
+ Hits          677      700      +23     
  Misses        163      163              
  Partials       28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

hwbrzzl
hwbrzzl requested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic is good, please optimize the unit test. 👍

go.mod Outdated Show resolved Hide resolved
@kkumar-gcc kkumar-gcc requested a review from hwbrzzl December 15, 2023 16:27
hwbrzzl
hwbrzzl reviewed Dec 16, 2023
View reviewed changes
context_request_test.go Outdated Show resolved Hide resolved
context_response_test.go Show resolved Hide resolved
hwbrzzl
hwbrzzl reviewed Dec 16, 2023
View reviewed changes
context_response_test.go Outdated Show resolved Hide resolved
hwbrzzl
hwbrzzl approved these changes Dec 16, 2023
View reviewed changes
Copy link
Contributor

@hwbrzzl hwbrzzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job 👍

@kkumar-gcc kkumar-gcc merged commit 186d13a into master Dec 16, 2023
7 checks passed
@kkumar-gcc kkumar-gcc deleted the kkumar-gcc/#271 branch December 16, 2023 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwbrzzl hwbrzzl hwbrzzl approved these changes

@devhaozi devhaozi Awaiting requested review from devhaozi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kkumar-gcc @devhaozi @codecov-commenter @hwbrzzl