Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please DEPRECATE this repo #9

Open
bradoyler opened this issue Jan 29, 2022 · 0 comments · May be fixed by #10
Open

Please DEPRECATE this repo #9

bradoyler opened this issue Jan 29, 2022 · 0 comments · May be fixed by #10

Comments

@bradoyler
Copy link
Member

bradoyler commented Jan 29, 2022

this is an anti-pattern that shouldn't be used. Key vault should only be fetched when the app is deployed not on every app restart.

Why would we need to fetch keyvault this way? and not use the Azure suggested approach: https://docs.microsoft.com/en-us/azure/app-service/app-service-key-vault-references ?

@bradoyler bradoyler linked a pull request Jan 29, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant