Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change fast-deep-equal to a ESM Library #610

Open
faragos opened this issue May 11, 2023 · 6 comments · May be fixed by #893
Open

Change fast-deep-equal to a ESM Library #610

faragos opened this issue May 11, 2023 · 6 comments · May be fixed by #893
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@faragos
Copy link

faragos commented May 11, 2023

Is your feature request related to a problem? Please describe.
When i build my Angular project there is a warning about fast-deep-equal because it is a commonJS/AMD module whcih can't be optimized correctly

/@googlemaps/markerclusterer/dist/index.esm.js depends on 'fast-deep-equal'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies

Describe the solution you'd like
Change the library to a ESM one or implement it in a native way.

Describe alternatives you've considered
Waiting until the library supports ESM. But this doesn't look like it will happen, because the Pull Request is already open for over a year.

epoberezkin/fast-deep-equal#105
@faragos faragos added triage me I really want to be triaged. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 11, 2023
@wangela
Copy link
Member

wangela commented May 11, 2023

If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.

@faragos Thank you for opening this issue. 🙏
Please check out these other resources that might help you get to a resolution in the meantime:

This is an automated message, feel free to ignore.

@felixranesberger felixranesberger mentioned this issue Jul 17, 2023
Open
@felixranesberger
Copy link

Hi @wangela, should the 👍 be placed on your automated comment, or the original issue description from @faragos ?

@wangela
Copy link
Member

wangela commented Jul 18, 2023

@felixranesberger the original description, since GitHub issue sorting looks at the count of emojis on the first comment only. I'll update the automated template! Thanks for calling my attention to the high number of votes on the automated comment.

@wangela wangela added priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. and removed triage me I really want to be triaged. labels Jul 18, 2023
@twitchax
Copy link

twitchax commented Nov 7, 2023

+1 here, as well. Using rollup with @open-wc/building-rollup.

@JshGrn
Copy link

JshGrn commented Jan 4, 2024

Any update on the status of this?

@byt3sage byt3sage linked a pull request Jul 5, 2024 that will close this issue
Open
4 tasks
@byt3sage
Copy link

byt3sage commented Jul 5, 2024

Hey!
I've just opened a PR to change fast-deep-equal to fast-equals which has ESM support. :)

@trygve-lie trygve-lie mentioned this issue Aug 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: replaced fast-deep-equal with fast-equals byt3sage/js-markerclusterer
6 participants
@twitchax @wangela @faragos @felixranesberger @byt3sage @JshGrn