New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid direct assignment of innerHTML for Advanced Marker-based cluster pins #729

Closed

wangela opened this issue Aug 15, 2023 · 1 comment

Labels

priority: p2 type: bug

Member

wangela commented Aug 15, 2023

renderer.ts uses innerHTML to define a pin element based on an inline SVG. This may trigger warnings about XSS vulnerabilities.

Recommended remedies:

(Preferred) Follow the pattern in the Advanced Markers SVG customization guide
Replace the full match with: safeElement.setInnerHtml(div, sanitizeHtmlAssertUnchanged(svg))

wangela added type: bug triage me priority: p1 priority: p2 and removed triage me priority: p1 labels

sandeepk-e mentioned this issue

fix: avoid direct assignment of innerHTML for Advanced Marker-based c… #744

Merged

Contributor

usefulthink commented Sep 29, 2023

fixed in #744

usefulthink closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment