Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Division by 0 #9

Open
lb-lmit opened this issue Jun 19, 2020 · 1 comment
Open

Division by 0 #9

lb-lmit opened this issue Jun 19, 2020 · 1 comment

Comments

@lb-lmit
Copy link

lb-lmit commented Jun 19, 2020 •
edited
Loading

Hello,
using the connector we are facing an error about division by 0 when usage.amount is equal to 0.

Please could you check the queries and fix it?

cc-gke-usage-metering/src/query.ts

Line 57 in 107cf72

SUM(cost) / SUM(usage.amount) AS rate

cc-gke-usage-metering/src/query.ts

Line 275 in 107cf72

SUM(cost) / SUM(usage.amount) AS rate

I have fix the query changing with SAFE_DIVIDE(SUM(cost), SUM(usage.amount)), but I can't fix it using the connector.
korolvvn added a commit to korolvvn/cc-gke-usage-metering that referenced this issue Feb 16, 2021
@korolvvn
googledatastudio#9
c7256fb 
try to fix zero division error
@korolvvn korolvvn mentioned this issue Feb 16, 2021
Open
@korolvvn
Copy link

@diminishedprime @sarandia hi, will this repository be updated in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@korolvvn @lb-lmit