Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockingProcessStreamReader stalls when a subprocess is waiting on user input #1954

Closed
jainsahab opened this issue Mar 6, 2023 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@jainsahab
Copy link
Contributor

After analysing googleapis/java-datastore#302 , we have a scenario where in some cases user can run commands which requires user input (manual intervention) and in those cases BlockingProcessStreamReader blocks on the following line waiting for the user input to happen, We do not flush the logs until an error happens, due to this user will never know what happened and there is no way they can pass the user input.

https://github.com/googleapis/google-cloud-java/blob/b72fe9d68c5892b587a5be36ba12b33165a71be9/java-core/google-cloud-core/src/main/java/com/google/cloud/testing/BlockingProcessStreamReader.java#L59

We probably have to put a timeout while starting a subprocess and dump all the startup logs incase the timeout happens, so that user gets the correct feedback.

@burkedavison burkedavison added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Mar 6, 2023
@suztomo suztomo transferred this issue from googleapis/google-cloud-java Aug 31, 2023
@suztomo
Copy link
Member

suztomo commented Aug 31, 2023

java-core is sdk-platform-java. Transferred the issue.

@meltsufin meltsufin added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jan 9, 2024
@blakeli0
Copy link
Collaborator

This is a very niche use case of local emulator testing, and the parent issue is not a priority at this moment. Closing as not planned for now, please re-open the issue if the parent issue becomes a priority again.

@blakeli0 blakeli0 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

5 participants