From 9a65386dfc3146de4f9b36962caae2df0662ac98 Mon Sep 17 00:00:00 2001 From: Joe Wang <106995533+JoeWang1127@users.noreply.github.com> Date: Fri, 20 Dec 2024 18:18:36 +0000 Subject: [PATCH] docs: update development guide (#3480) In this PR: - Update development guide on the integration test. --- hermetic_build/DEVELOPMENT.md | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/hermetic_build/DEVELOPMENT.md b/hermetic_build/DEVELOPMENT.md index 6bdb46a272..e1b933f15c 100644 --- a/hermetic_build/DEVELOPMENT.md +++ b/hermetic_build/DEVELOPMENT.md @@ -25,15 +25,14 @@ python -m pip install hermetic_build/release_note_generation # Run the integration tests The integration tests build the docker image declared in -`.cloudbuild/library_generation/library_generation.Dockerfile`, pull GAPIC -repositories, generate the libraries and compare the results with the source -code declared in a "golden branch" of the repo. +`.cloudbuild/library_generation/library_generation.Dockerfile`, pull API +definitions and GAPIC repositories, generate the libraries and compare the +results with the source code declared in a "golden branch" of the repo. -It requires docker and python (>= 3.12.0) to be installed. +The integration tests are running in Cloud Build rather than GitHub workflow +because the workflow doesn't have permission to pull images from Airlock. -```shell -python -m unittest hermetic_build/library_generation/tests/integration_tests.py -``` +The Cloud Build job is defined in `.cloudbuild/library_generation/cloudbuild-library-generation-integration-test.yaml` and runs in every pull request. # Run the unit tests