Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy does not recognize a not implemented async method as an async generator #703

Open
ohmayr opened this issue Sep 20, 2024 · 0 comments
Open
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@ohmayr
Copy link
Contributor

ohmayr commented Sep 20, 2024

mypy does not recognize the abstract async content method from google.auth.aio.transport.Response as an async generator because it looks for the yield keyword and the abstract method is not implemented. Currently, we've silenced mypy for this issue since the code works as expected.

Follow up on this issue and remove # type: ignore from the relevant spot when fixed. This can be looked up by searching for this issue in the code.

self._response_itr = self._response.content().__aiter__()

@ohmayr ohmayr added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Sep 20, 2024
@vchudnov-g vchudnov-g removed their assignment Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants