Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support CustomWriterIdentity #1647

Open
johnclara opened this issue Jun 24, 2024 · 2 comments
Open

Support CustomWriterIdentity #1647

johnclara opened this issue Jun 24, 2024 · 2 comments
Assignees
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release.

Comments

@johnclara
Copy link

Thanks for stopping by to let us know something could be better!

PLEASE READ: If you have a support contract with Google, please create an issue in the support console instead of filing on GitHub. This will ensure a timely response.

Is your feature request related to a problem? Please describe.
I think we should be able to set a customWriterIdentity in a CreateSinkRequest. Based on rest api: https://cloud.google.com/logging/docs/reference/v2/rest/v2/organizations.sinks/create

Describe the solution you'd like
Allow setting custom writer identity.

Describe alternatives you've considered

Additional context

@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/java-logging API. label Jun 24, 2024
@johnclara
Copy link
Author

@cindy-peng any update on this? Is this on the roadmap or is there a different way to implement this?

@cindy-peng cindy-peng added the priority: p3 Desirable enhancement or fix. May not be included in next release. label Nov 4, 2024
@cindy-peng
Copy link
Contributor

Sorry for the late reply @johnclara! I agree that adding CustomWriterIdentity parameter makes sense for the library. Unfortunately the team has been busy working on some other projects. I've added your request to our list and will let you know as soon as we have a plan in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. priority: p3 Desirable enhancement or fix. May not be included in next release.
Projects
None yet
Development

No branches or pull requests

2 participants