Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Introducing Tracing with OpenTelemetry API #1537

Closed
wants to merge 41 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
d84aae4
feat: Adding TraceUtil interface and its implementation to enable Tra…
jimit-j-shah May 8, 2024
77810da
feat: Adding Lookup RPC OpenTelemetry Tracing (#1437)
jimit-j-shah May 15, 2024
730aa42
feat: Adding Commit RPC Trace Instrumentation (#1440)
jimit-j-shah May 20, 2024
602c5e3
feat: RunQuery trace instrumentation (#1441)
jimit-j-shah May 23, 2024
1e4e7ca
feat: RunAggregationQuery instrumentation (#1447)
jimit-j-shah May 23, 2024
52329e4
feat: RunQuery trace instrumentation
jimit-j-shah May 15, 2024
de05e49
Formatting
jimit-j-shah May 15, 2024
a9965db
Formatting
jimit-j-shah May 15, 2024
3fef66f
Refactor: s/RUNQUERY/RUN_QUERY
jimit-j-shah May 16, 2024
fb8a28e
feat: RunAggregationQuery Trace Instrumentation
jimit-j-shah May 16, 2024
02d178d
Build: retiring test assertions for OpenCensus spans - will be replac…
jimit-j-shah May 16, 2024
a2a2f03
Formatting
jimit-j-shah May 17, 2024
73241a2
Fixing @Test annotation missed after merge
jimit-j-shah May 20, 2024
75a98b4
Formatting
jimit-j-shah May 20, 2024
585181f
feat: Add Transaction tracing
jimit-j-shah May 21, 2024
4edc2ef
test: Transaction test for RunInTransaction - need to fix trace instr…
jimit-j-shah May 21, 2024
22571ea
Adding transaction span names
jimit-j-shah May 23, 2024
3076735
TransactionLookupTest
jimit-j-shah May 23, 2024
8dca867
feat: support for transactional operations
jimit-j-shah May 30, 2024
66cebbb
Revert "feat: support for transactional operations"
jimit-j-shah May 30, 2024
24779b9
feat: support for transactional operations (#1468)
jimit-j-shah Jun 7, 2024
552d04e
feat: Allocateid tracing (#1488)
jimit-j-shah Jun 19, 2024
975464a
feat: Add tracing for ReserveIds operation (#1490)
jimit-j-shah Jun 25, 2024
27caf81
fix: Fixed Span nesting for `ReadWriteTransactionCallable` by using p…
jimit-j-shah Jun 27, 2024
31a6f4a
test: Additional Transaction Testing and cleanup OpenCensus usage (#1…
jimit-j-shah Jul 2, 2024
536c2d9
test: Adding ITTracingTest to verify events and span attributes (whic…
jimit-j-shah Jul 10, 2024
6944e1b
test: Additional Transaction tests and AggregationQuery test (#1518)
jimit-j-shah Jul 19, 2024
5652dd4
fix: Undelete gRPC upgrade docs
jimit-j-shah Aug 5, 2024
aa00fe2
fix: Undo merge mistakes
jimit-j-shah Aug 5, 2024
3a3d7b8
fix: Updating span event strings (#1539)
jimit-j-shah Aug 6, 2024
3640051
Fix: typo in test causing integration test failure (#1556)
jimit-j-shah Sep 4, 2024
f787871
chore(main): release 2.21.0 (#1517)
release-please[bot] Aug 5, 2024
a880548
deps: update dependency com.google.cloud:sdk-platform-java-config to …
renovate-bot Aug 6, 2024
fb43b23
chore(main): release 2.21.1-SNAPSHOT (#1538)
release-please[bot] Aug 6, 2024
2fdc90a
chore(deps): update dependency com.google.cloud:libraries-bom to v26.…
renovate-bot Aug 6, 2024
1706dd5
chore(main): release 2.21.1 (#1540)
release-please[bot] Aug 6, 2024
0b496ba
chore(main): release 2.21.2-SNAPSHOT (#1541)
release-please[bot] Aug 20, 2024
16b3515
chore: secure hermetic_library_generation workflow (#1552)
diegomarquezp Aug 20, 2024
ea98972
deps: update dependency com.google.cloud:sdk-platform-java-config to …
renovate-bot Aug 22, 2024
fb4bd08
chore(main): release 2.21.2 (#1553)
release-please[bot] Aug 23, 2024
3be4fb7
chore: remove datastore native image sample in favor of sample hosted…
mpeddada1 Aug 27, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions .github/workflows/hermetic_library_generation.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,14 @@ name: Hermetic library generation upon generation config change through pull req
on:
pull_request:

env:
HEAD_REF: ${{ github.head_ref }}
REPO_FULL_NAME: ${{ github.event.pull_request.head.repo.full_name }}

jobs:
library_generation:
# skip pull requests coming from a forked repository
if: github.event.pull_request.head.repo.full_name == github.repository
jimit-j-shah marked this conversation as resolved.
Show resolved Hide resolved
if: github.env.REPO_FULL_NAME == github.repository
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -30,11 +34,11 @@ jobs:
- name: Generate changed libraries
shell: bash
run: |
set -x
set -ex
[ -z "$(git config user.email)" ] && git config --global user.email "[email protected]"
[ -z "$(git config user.name)" ] && git config --global user.name "cloud-java-bot"
bash .github/scripts/hermetic_library_generation.sh \
--target_branch ${{ github.base_ref }} \
--current_branch ${{ github.head_ref }}
--current_branch $HEAD_REF
env:
GH_TOKEN: ${{ secrets.CLOUD_JAVA_BOT_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/unmanaged_dependency_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@ jobs:
shell: bash
run: .kokoro/build.sh
- name: Unmanaged dependency check
uses: googleapis/sdk-platform-java/java-shared-dependencies/unmanaged-dependency-check@google-cloud-shared-dependencies/v3.32.0
uses: googleapis/sdk-platform-java/java-shared-dependencies/unmanaged-dependency-check@google-cloud-shared-dependencies/v3.34.0
with:
bom-path: google-cloud-datastore-bom/pom.xml
2 changes: 1 addition & 1 deletion .kokoro/presubmit/graalvm-native-17.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Configure the docker image for kokoro-trampoline.
env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.32.0"
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_b:3.34.0"
}

env_vars: {
Expand Down
2 changes: 1 addition & 1 deletion .kokoro/presubmit/graalvm-native.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
# Configure the docker image for kokoro-trampoline.
env_vars: {
key: "TRAMPOLINE_IMAGE"
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.32.0"
value: "gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform_a:3.34.0"
}

env_vars: {
Expand Down
21 changes: 21 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,26 @@
# Changelog

## [2.21.2](https://github.com/googleapis/java-datastore/compare/v2.21.1...v2.21.2) (2024-08-22)


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.34.0 ([#1547](https://github.com/googleapis/java-datastore/issues/1547)) ([8c5f595](https://github.com/googleapis/java-datastore/commit/8c5f5954d88732ab929b4477a3f15b0052adc2ff))

## [2.21.1](https://github.com/googleapis/java-datastore/compare/v2.21.0...v2.21.1) (2024-08-06)


### Dependencies

* Update dependency com.google.cloud:sdk-platform-java-config to v3.33.0 ([#1531](https://github.com/googleapis/java-datastore/issues/1531)) ([9e52395](https://github.com/googleapis/java-datastore/commit/9e52395f7ee71315331790284d35e7aad2f387ed))

## [2.21.0](https://github.com/googleapis/java-datastore/compare/v2.20.2...v2.21.0) (2024-07-31)


### Features

* Enable hermetic library generation ([#1462](https://github.com/googleapis/java-datastore/issues/1462)) ([d142d9c](https://github.com/googleapis/java-datastore/commit/d142d9c95d91c8cadaf696efc12d6136814938ff))

## [2.20.2](https://github.com/googleapis/java-datastore/compare/v2.20.1...v2.20.2) (2024-06-28)


Expand Down
4 changes: 2 additions & 2 deletions datastore-v1-proto-client/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -19,12 +19,12 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud.datastore</groupId>
<artifactId>datastore-v1-proto-client</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:datastore-v1-proto-client:current} -->
<version>2.21.2</version><!-- {x-version-update:datastore-v1-proto-client:current} -->

<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore-parent</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:google-cloud-datastore:current} -->
<version>2.21.2</version><!-- {x-version-update:google-cloud-datastore:current} -->
</parent>

<packaging>jar</packaging>
Expand Down
12 changes: 6 additions & 6 deletions google-cloud-datastore-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore-bom</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:google-cloud-datastore-bom:current} -->
<version>2.21.2</version><!-- {x-version-update:google-cloud-datastore-bom:current} -->
<packaging>pom</packaging>
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>sdk-platform-java-config</artifactId>
<version>3.32.0</version>
<version>3.34.0</version>
</parent>

<name>Google Cloud datastore BOM</name>
Expand Down Expand Up @@ -52,22 +52,22 @@
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:google-cloud-datastore:current} -->
<version>2.21.2</version><!-- {x-version-update:google-cloud-datastore:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>grpc-google-cloud-datastore-admin-v1</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:grpc-google-cloud-datastore-admin-v1:current} -->
<version>2.21.2</version><!-- {x-version-update:grpc-google-cloud-datastore-admin-v1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-datastore-v1</artifactId>
<version>0.111.3-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-datastore-v1:current} -->
<version>0.112.2</version><!-- {x-version-update:proto-google-cloud-datastore-v1:current} -->
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-datastore-admin-v1</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:proto-google-cloud-datastore-admin-v1:current} -->
<version>2.21.2</version><!-- {x-version-update:proto-google-cloud-datastore-admin-v1:current} -->
</dependency>
</dependencies>
</dependencyManagement>
Expand Down
12 changes: 12 additions & 0 deletions google-cloud-datastore/clirr-ignored-differences.xml
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,16 @@
<method>java.lang.Object execute(com.google.cloud.datastore.Query, com.google.cloud.datastore.ReadOption[])</method>
<differenceType>7004</differenceType>
</difference>
<difference>
<className>com/google/cloud/datastore/RetryAndTraceDatastoreRpcDecorator</className>
<method>RetryAndTraceDatastoreRpcDecorator(com.google.cloud.datastore.spi.v1.DatastoreRpc, com.google.cloud.datastore.TraceUtil, com.google.api.gax.retrying.RetrySettings, com.google.cloud.datastore.DatastoreOptions)</method>
<to>RetryAndTraceDatastoreRpcDecorator(com.google.cloud.datastore.spi.v1.DatastoreRpc, com.google.cloud.datastore.telemetry.TraceUtil, com.google.api.gax.retrying.RetrySettings, com.google.cloud.datastore.DatastoreOptions)</to>
<differenceType>7005</differenceType>
</difference>

<!-- Class removed -->
<difference>
<className>com/google/cloud/datastore/TraceUtil</className>
<differenceType>8001</differenceType>
</difference>
</differences>
90 changes: 87 additions & 3 deletions google-cloud-datastore/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
<modelVersion>4.0.0</modelVersion>
<artifactId>google-cloud-datastore</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:google-cloud-datastore:current} -->
<version>2.21.2</version><!-- {x-version-update:google-cloud-datastore:current} -->
<packaging>jar</packaging>
<name>Google Cloud Datastore</name>
<url>https://github.com/googleapis/java-datastore</url>
Expand All @@ -12,11 +12,24 @@
<parent>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-datastore-parent</artifactId>
<version>2.20.3-SNAPSHOT</version><!-- {x-version-update:google-cloud-datastore:current} -->
<version>2.21.2</version><!-- {x-version-update:google-cloud-datastore:current} -->
</parent>
<properties>
<site.installationModule>google-cloud-datastore</site.installationModule>
<opentelemetry.version>1.39.0</opentelemetry.version>
</properties>
<dependencyManagement>
<dependencies>
<dependency>
<!-- Artifacts from google-cloud-java monorepo -->
<groupId>com.google.cloud</groupId>
<artifactId>gapic-libraries-bom</artifactId>
<version>1.37.0</version>
<type>pom</type>
<scope>import</scope>
</dependency>
</dependencies>
</dependencyManagement>
<dependencies>
<dependency>
<groupId>com.google.api.grpc</groupId>
Expand All @@ -38,6 +51,10 @@
<groupId>com.google.cloud.datastore</groupId>
<artifactId>datastore-v1-proto-client</artifactId>
</dependency>
<dependency>
<groupId>com.google.auth</groupId>
<artifactId>google-auth-library-credentials</artifactId>
</dependency>
<dependency>
<groupId>io.grpc</groupId>
<artifactId>grpc-api</artifactId>
Expand Down Expand Up @@ -111,14 +128,31 @@
<artifactId>jsr305</artifactId>
</dependency>

<!-- OpenTelemetry -->
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk</artifactId>
jimit-j-shah marked this conversation as resolved.
Show resolved Hide resolved
<version>${opentelemetry.version}</version>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-api</artifactId>
<version>${opentelemetry.version}</version>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-context</artifactId>
<version>${opentelemetry.version}</version>
</dependency>
<!-- END OpenTelemetry -->

<!-- Test dependencies -->
<dependency>
<groupId>${project.groupId}</groupId>
<artifactId>google-cloud-core</artifactId>
<type>test-jar</type>
<scope>test</scope>
</dependency>

<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava-testlib</artifactId>
Expand Down Expand Up @@ -160,6 +194,56 @@
<version>1.4.3</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.testparameterinjector</groupId>
<artifactId>test-parameter-injector</artifactId>
<version>1.16</version>
<scope>test</scope>
</dependency>
<!-- OpenTelemetry -->
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-common</artifactId>
<version>${opentelemetry.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-testing</artifactId>
<version>${opentelemetry.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-sdk-trace</artifactId>
<version>${opentelemetry.version}</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>io.opentelemetry</groupId>
<artifactId>opentelemetry-semconv</artifactId>
<version>1.1.0-alpha</version>
<scope>test</scope>
</dependency>
<!-- END OpenTelemetry -->
<!-- Cloud Ops -->
<dependency>
<groupId>com.google.cloud.opentelemetry</groupId>
jimit-j-shah marked this conversation as resolved.
Show resolved Hide resolved
<artifactId>exporter-trace</artifactId>
<version>0.15.0</version>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-trace</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>com.google.api.grpc</groupId>
<artifactId>proto-google-cloud-trace-v1</artifactId>
<scope>test</scope>
</dependency>
<!-- END Cloud Ops -->
</dependencies>

<build>
Expand Down
Loading
Loading