Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gapic: refactor plugins to Go Protobuf v2 plugin API #348

Open
noahdietz opened this issue Mar 31, 2020 · 4 comments
Open

gapic: refactor plugins to Go Protobuf v2 plugin API #348

noahdietz opened this issue Mar 31, 2020 · 4 comments
Assignees
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@noahdietz
Copy link
Collaborator

Recently, the v2 of the Go Protobuf API was released, that included improvements to the protoc plugin API. We should upgrade and refactor the Go micro-generator to use google.golang.org/protobuf/compiler/protogen (godoc). This could significantly reduce the amount of hand-spun utility code in the Go micro-generator.

This would also probably mean significant changes to all three generators: gengapic, gencli, gensample.

@noahdietz noahdietz added the type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. label Mar 31, 2020
@noahdietz noahdietz self-assigned this Mar 31, 2020
@noahdietz
Copy link
Collaborator Author

Blog post about the new package for posterity.

@tmc
Copy link

tmc commented May 9, 2020

I can attest that the new api is 🔥

@odsod
Copy link
Contributor

odsod commented Jul 15, 2020

@noahdietz Support for input on textpb format would also be super useful.

@noahdietz
Copy link
Collaborator Author

@odsod would you mind opening a separate issue fro a feature request please? This issue is a backlog item to migrate protobuf APIs in the protoc plugin implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants