From ab0daa685cc4de8b61c2e8c44ad5ef1cc1b6c602 Mon Sep 17 00:00:00 2001 From: James McTavish Date: Wed, 20 Dec 2023 11:33:51 -0500 Subject: [PATCH 1/2] fix: increase capture limit to allow Windows tests to pass --- test/test-v8debugapi.ts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/test/test-v8debugapi.ts b/test/test-v8debugapi.ts index d907fbaf..6d20e019 100644 --- a/test/test-v8debugapi.ts +++ b/test/test-v8debugapi.ts @@ -1123,13 +1123,12 @@ describe('v8debugapi', () => { const bp: stackdriver.Breakpoint = { id: 'fake-id-124', // TODO(dominickramer): This path can be lest strict when this file has - // been - // converted to Typescript. + // been converted to Typescript. location: {path: 'build/test/test-v8debugapi-code.js', line: 10}, expressions: ['process.env', 'hasGetter'], } as {} as stackdriver.Breakpoint; const oldMaxData = config.capture.maxDataSize; - config.capture.maxDataSize = 20000; + config.capture.maxDataSize = 200000; api.set(bp, err1 => { assert.ifError(err1); api.wait(bp, err2 => { From 79922493d4265f274007654d288bb63ecd71907d Mon Sep 17 00:00:00 2001 From: James McTavish Date: Wed, 20 Dec 2023 13:24:41 -0500 Subject: [PATCH 2/2] Add a comment explaining the boosted value --- test/test-v8debugapi.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/test/test-v8debugapi.ts b/test/test-v8debugapi.ts index 6d20e019..0a843c6f 100644 --- a/test/test-v8debugapi.ts +++ b/test/test-v8debugapi.ts @@ -1128,6 +1128,7 @@ describe('v8debugapi', () => { expressions: ['process.env', 'hasGetter'], } as {} as stackdriver.Breakpoint; const oldMaxData = config.capture.maxDataSize; + // Note the boosted maxDataSize to accommodate tests run on Windows. config.capture.maxDataSize = 200000; api.set(bp, err1 => { assert.ifError(err1);