Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanner Dialect - ALTER INDEX Unexpected Error #147

Open
SDorgan opened this issue Aug 23, 2023 · 1 comment
Open

Spanner Dialect - ALTER INDEX Unexpected Error #147

SDorgan opened this issue Aug 23, 2023 · 1 comment

Comments

@SDorgan
Copy link

SDorgan commented Aug 23, 2023

Hello,
According to documentation, the ALTER INDEX statement should follow this example:

ALTER INDEX index_name {ADD|DROP} STORED COLUMN column_name

Reference: https://cloud.google.com/spanner/docs/secondary-indexes#googlesql_5

That said, while trying out the parser in the following piece of code

String query = <My script>;
LanguageOptions languageOptions = new LanguageOptions();
ASTNodes.ASTScript parsedScript = Parser.parseScript(query, languageOptions);

I found that:

  • When query was:
ALTER INDEX i1 DROP STORED COLUMN author;

The Parser returns: Unexpected keyword STORED [at 1:21]

  • When query was:
ALTER INDEX i1 DROP COLUMN author;

The Parser returns: ALTER INDEX is not supported [at 1:7]

  • When query was:
ALTER INDEX i1 ADD COLUMN author;

The Parser returns: Unexpected ";" [at 1:33]

  • When query was:
ALTER INDEX i1 ADD STORED COLUMN author;

The Parser returns: Unexpected keyword STORED [at 1:20]

I was wondering if this was the expected result and if ALTER INDEX will be supported in the future.
Thanks

@apstndb
Copy link

apstndb commented Sep 28, 2024

It seems that FEATURE_SPANNER_LEGACY_DDL has not been updated in a long time, and DDL of ZetaSQL and Cloud Spanner has no clear plan to be compatible.

Cloud Spanner Emulator have the its own DDL parser, but it is not exported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants