-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dslx_fmt should not delete code w/ waiver #1746
Comments
proppy
added
dslx:fmt
DSLX auto-formatter
bug
Something isn't working or is incorrect
labels
Nov 28, 2024
Might be a duplicate of #1735 |
I think this happens because the AST contains two copies of everything from a proc: the "extracted" methods (e.g., matmul.init, matmul.config, matmul.next) and the "original" proc node. They're processed in sequence, and the format disabler is getting confused regarding which nodes should be converted to VerbatimNodes. |
#1029 describes the issue more. |
Duplicate of #1735 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
It seems that the formatter sometimes erroneously delete code when
dslx-fmt::
waiver are being used.To Reproduce
Running
dslx_fmt
on:"reformat" the code into:
Expected behavior
The proc definition above should not be deleted.
Additional context
Note that removing the
dslx-fmt::
waiver workaround this issue and properly reformat the code.The text was updated successfully, but these errors were encountered: