Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: turbinia-client not showing flag help text #1375

Open
aarontp opened this issue Oct 13, 2023 · 3 comments
Open

[FR]: turbinia-client not showing flag help text #1375

aarontp opened this issue Oct 13, 2023 · 3 comments

Comments

@aarontp
Copy link
Member

aarontp commented Oct 13, 2023

What would this feature improve or what problem would it solve?

Would be able to see more details of the flags to know how to use the client better.

What is the feature you are proposing?

Not sure why, but the turbinia client is not showing the help text for the flags here:

$ turbinia-client submit googleclouddisk -h
2023-10-13 16:53:38,575 INFO turbinia - Using configuration instance name -> default with host http://localhost:8000
Usage: turbinia-client submit googleclouddisk [OPTIONS]

Options:
  --project TEXT          [default: (project); required]
  --zone TEXT             [default: (zone); required]
  --disk_name TEXT        [default: (disk_name); required]
  --mount_partition TEXT  [default: (mount_partition)]
  --name TEXT             [default: (name)]
  --tags TEXT             [default: (tags)]
  --source TEXT           [default: (source)]
  --description TEXT      [default: (description)]
  --recipe_name TEXT      [default: (recipe_name)]
  --recipe_data TEXT      [default: (recipe_data)]
  --jobs_allowlist TEXT   [default: (jobs_allowlist)]
  --jobs_denylist TEXT    [default: (jobs_denylist)]
  --filter_patterns TEXT  [default: (filter_patterns)]
  --yara_rules TEXT       [default: (yara_rules)]
  --sketch_id TEXT        [default: (sketch_id)]
  --group_id TEXT         [default: (group_id)]
  --reason TEXT           [default: (reason)]
  --request_id TEXT       [default: (request_id)]
  --requester TEXT        [default: (requester)]
  -h, --help              Show this message and exit.

What alternatives have you considered?

No response

@aarontp aarontp added enhancement Needs triage New issues that need triage labels Oct 13, 2023
@aarontp
Copy link
Member Author

aarontp commented Oct 13, 2023

FYI @jleaniz

@jleaniz
Copy link
Collaborator

jleaniz commented Oct 13, 2023

Yeah, these flags are automatically generated based on the object attributes, so I'm not sure how we could add text to that dynamically without hardcoding some text and mapping text to options. The only thing i can think of is to somehow grab the text from the class docstring if there's a way to do that.

@jleaniz
Copy link
Collaborator

jleaniz commented Oct 13, 2023

I'll give that a shot to see if we can use the class attributes docstring as a help message and pass this to the client via the API. I assume that's not an issue because the "submit" sub-commands wouldn't be generated without being able to contact the API in the first place.

@aarontp aarontp removed the Needs triage New issues that need triage label Jan 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants