Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Datahub Fingerprint Database and update script #316

Merged
merged 14 commits into from
Feb 20, 2024

Conversation

timoles
Copy link
Contributor

@timoles timoles commented Apr 23, 2023

Reference to issue #289

Sorry for the delay, the PR is almost ready.

Open points (from my side):

  • Include linkedin/datahub-frontend in the results (<v7.0)
  • Remove volume from compose file
  • Add complete and tested binproto file

@timoles
Copy link
Contributor Author

timoles commented Apr 24, 2023

Hey @maoning ,

the PR should be done. However, my local DataHub instance is not detected by the fingerprinter.

Do you know some decent way to debug why Tsunami doesn't detect DataHub?

I started the scan (as described in the Tsunami repo) with Tsunami running in docker. The only thing I changed in the Dockerfile was line 10 (https://github.com/google/tsunami-security-scanner/blob/master/Dockerfile#L10):

# Old Line 10
RUN git clone --depth 1 "https://github.com/google/tsunami-security-scanner-plugins"

# New line to pull from my fork
RUN git clone -b datahub-fingerprint --depth 1 "https://github.com/timoles/tsunami-security-scanner-plugins"

@timoles timoles changed the title WIP: ADD Datahub Fingerprint Database and update script Add Datahub Fingerprint Database and update script Apr 24, 2023
@timoles
Copy link
Contributor Author

timoles commented Apr 25, 2023

I just got a tip that I just need to run tsunami with the --uri-target args. This seems to do the trick, and Tsunami correctly identifies the webservice (and DataHub).

docker run --network="host" -v "$(pwd)/logs":/usr/tsunami/logs tsunami --uri-target=http://127.0.0.1:9002/

image

@maoning , you can review the PR if you have time, it should be complete.

@timoles
Copy link
Contributor Author

timoles commented Dec 5, 2023

Any updates regarding the merge of this PR?

@tooryx
Copy link
Member

tooryx commented Jan 10, 2024

Hi @timoles,

Thank you for your contribution! I will be taking a look into this in a few days. But I see a few TODO comments and commented code portion in the docker-compose script. Are there things that you still want to implement before the PR is complete?

~tooryx

@tooryx tooryx self-assigned this Jan 10, 2024
Remove trailing space
Add terminating newline
@tooryx tooryx added Contributor main The main issue a contributor is working on (top of the contribution queue). fingerprints labels Feb 1, 2024
@tooryx tooryx linked an issue Feb 13, 2024 that may be closed by this pull request
Copy link
Member

@tooryx tooryx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment, the rest seems good. Thank you!

@tooryx
Copy link
Member

tooryx commented Feb 19, 2024

Looks good overall, I expect to finalize the review and merge in a few days.

~tooryx

@copybara-service copybara-service bot merged commit ee9f5af into google:master Feb 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributor main The main issue a contributor is working on (top of the contribution queue). fingerprints
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PRP: Datahub Fingerprint Database and update script
2 participants