-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Datahub Fingerprint Database and update script #316
Conversation
Hey @maoning , the PR should be done. However, my local DataHub instance is not detected by the fingerprinter. Do you know some decent way to debug why Tsunami doesn't detect DataHub? I started the scan (as described in the Tsunami repo) with Tsunami running in docker. The only thing I changed in the Dockerfile was line 10 (https://github.com/google/tsunami-security-scanner/blob/master/Dockerfile#L10): # Old Line 10
RUN git clone --depth 1 "https://github.com/google/tsunami-security-scanner-plugins"
# New line to pull from my fork
RUN git clone -b datahub-fingerprint --depth 1 "https://github.com/timoles/tsunami-security-scanner-plugins" |
I just got a tip that I just need to run tsunami with the
@maoning , you can review the PR if you have time, it should be complete. |
Any updates regarding the merge of this PR? |
Hi @timoles, Thank you for your contribution! I will be taking a look into this in a few days. But I see a few TODO comments and commented code portion in the docker-compose script. Are there things that you still want to implement before the PR is complete? ~tooryx |
Remove trailing space
Add terminating newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a comment, the rest seems good. Thank you!
google/fingerprinters/web/scripts/updater/community/datahub/update.sh
Outdated
Show resolved
Hide resolved
Minor: remove trailing space
Minor: add terminating newline
Looks good overall, I expect to finalize the review and merge in a few days. ~tooryx |
Reference to issue #289
Sorry for the delay, the PR is almost ready.
Open points (from my side):