Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a better approach for error handling in Cloud Build docker pull #67

Open
SoapHia opened this issue Dec 17, 2020 · 0 comments
Open

Comments

@SoapHia
Copy link
Collaborator

SoapHia commented Dec 17, 2020

args: ['-c', 'docker pull gcr.io/$PROJECT_ID/ts-bridge:latest || exit 0']
This step (originally copied from https://cloud.google.com/cloud-build/docs/speeding-up-builds#using_a_cached_docker_image) will mask all errors from docker pull, not just when image doesn't exist. Consider using a more optimal approach which can parse the output from docker pull to handle errors better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant