Skip to content

Commit

Permalink
Update platform.h with correct Apple detection macro.
Browse files Browse the repository at this point in the history 
Imported from #334

PiperOrigin-RevId: 534598605
  • Loading branch information
@bjacob @copybara-github
bjacob authored and copybara-github committed May 23, 2023
1 parent 72d107f commit 8997611
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ruy/platform.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ limitations under the License.
// Enable on sufficiently recent Android NDK. Earlier versions had broken
// intrinsics headers.
#define RUY_PLATFORM_X86_ENHANCEMENTS 1
#elif (defined(__APPLE__) || defined(__linux__)) && defined(__clang__) && \
#elif (defined(__APPLE_) || defined(__linux__)) && defined(__clang__) && \
(__clang_major__ >= 8)
// Enable on recent versions of Clang. Might be possible
// to relax this version requirement.
Expand Down

2 comments on commit 8997611

@georgthegreat
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something went wrong here.
This commit reverted a correct change made in #334

@bjacob
Copy link
Contributor Author

@bjacob bjacob commented on 8997611 May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exported commit message was confusing, something went wrong at that level, but the rollback itself is intentional: while correct, #334, precisely by correctly enabling x86 paths on Apple, triggerred an internal CI failure, forcing the rollback. Hopefully this will be resolved and we will be able to re-enable this.

Please sign in to comment.