[CMake] Added RE2_ENABLE_INSTALL #517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using re2 as a submodule via CMake, we need to prevent the re2 from being installed. This is because the re2 installation target expects to find installed Abseil targets, which aren't available when being used as a submodule.
To address this, I've added a new CMake option
RE2_ENABLE_INSTALL. This option controls whether re2 is installable and is set by default if it's used in a standard way. Hence, no change for the existing use-case is introduced. The only difference is when re2 is included as a submodule. In this specific case, re2 won't be installed by default. This will solve the missing Abseil dependency issue.