Skip to content
This repository has been archived by the owner on Jan 10, 2023. It is now read-only.

Fix RSA keyfile open mode (rb) for python3 (#141) #142

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

joeleong
Copy link

@joeleong joeleong commented Dec 11, 2018

Proposed fix for #141

I only really tested it with the m2crypto signer, but I assumed it would be the same for sign_pythonrsa.py

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@bibz
Copy link

bibz commented Dec 20, 2018

Experiencing the same issue, I validated the fix on my side with Python RSA 4.0 and Python 3.6:

$ cd $(mktemp -d)
$ git init .
$ git fetch https://github.com/joeleong/python-adb.git 3338e6baa4ce37523e5859094bf7b758b926c2e3
$ git checkout FETCH_HEAD
$ virtualenv -p python 3 venv
$ . ./venv/bin/activate
$ pip install rsa==4.0
$ pip install -e .

I followed the steps to reproduce as mentioned in #141 :

  1. Revoke USB debugging authorisation
  2. Run pyadb shell ls
  3. Acknowledge that the device now asks to allow access from the host

@joeleong
Copy link
Author

joeleong commented Jan 4, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@greyltc
Copy link

greyltc commented Sep 30, 2019

What needs to be done to get this merged? The bug in master that this PR fixes seems to make the project useless under python 3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants