Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement understanding of formatting verbs #288

Open
mlevesquedion opened this issue Mar 5, 2021 · 0 comments
Open

Implement understanding of formatting verbs #288

mlevesquedion opened this issue Mar 5, 2021 · 0 comments

Comments

@mlevesquedion
Copy link
Contributor

mlevesquedion commented Mar 5, 2021

Currently, the following can cause a report:

core.Sinkf("%T", source)

There is actually no issue in the above example: the type of a sensitive value is not sensitive.

We can likely borrow some logic from the printf analyzer.

If we want to be especially diligent, we could go through all the formatting verbs and determine how to handle each one. From a cursory glance, I think the relevant ones are %T, and maybe %s and %q. For these two, we could e.g. do some kind of analysis of the appropriate String() function for the corresponding argument.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant