[TS/Rust/Go/Dart] Fix handling of +/-inf defaults in codegen #7588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c#
c++
codegen
jkuszmaul
changed the title
jkuszmaul
force-pushed
the
ts_inf_default
branch
from
f5fb5ee
to
e2a4417
Compare
|
And I see Rust, Go, and Dart also don't handle this correctly..... |
jkuszmaul
force-pushed
the
ts_inf_default
branch
from
e2a4417
to
2a9ca91
Compare
jkuszmaul
changed the title
jkuszmaul
force-pushed
the
ts_inf_default
branch
2 times, most recently
from
cf01985
to
6bc90f0
Compare
CasperN
reviewed
Oct 17, 2022
jkuszmaul
force-pushed
the
ts_inf_default
branch
from
6bc90f0
to
ec2723a
Compare
jkuszmaul
changed the title
jkuszmaul
force-pushed
the
ts_inf_default
branch
2 times, most recently
from
817819a
to
1157ba8
Compare
|
Okay, everything is passing except for the Go test, and I must be blind because I cannot figure out what the Go test is failing on from looking at the output. |
They seem to be the same up to addresses |
jkuszmaul
force-pushed
the
ts_inf_default
branch
from
1157ba8
to
1f99322
Compare
jkuszmaul
force-pushed
the
ts_inf_default
branch
2 times, most recently
from
d09a4b7
to
09b57fd
Compare
+/-inf were not being handled, and so invalid typescript was being generated when a float/double had an infinite default value. NaN was being handled correctly.
jkuszmaul
force-pushed
the
ts_inf_default
branch
from
09b57fd
to
dba2a5f
Compare
CasperN
previously approved these changes
Oct 26, 2022
|
The Kotlin MacOS build looks just flaky, not sure how to rerun it (other than just making a dummy commit or rebasing on mater again or some similarly silly thing). |
|
@CasperN @dbaileychess The Kotlin Linux build seems to have flaked out this time; not quite sure what the appropriate response from me is when builds fail in this manner, or if I've just gotten particularly unlucky with flakiness to have two different Kotlin tests flake out in a row. |
|
I updated that runner e545361 due to this thread: gradle/wrapper-validation-action#40 |
|
Sorry, i mistyped the fix, rerunning the CI. |
dbaileychess
approved these changes
Nov 8, 2022
frc971-automation
pushed a commit
to frc971/971-Robot-Code
that referenced
this pull request
Dec 13, 2022
Update flatbuffers. Relevant merge tasks: * A field got added to reflection.fbs; this had fallout in reflection_generated.h and the logger_test shas. * Resolved merge conflict in rust/flatbuffers/src/lib.rs * Reverted upstream change that made Table rust struct members private. * FlatBufferBuilder Create*Vector calls now include alignment. * nim codegen got added; needed to update to use scoped enums. Main fix that motivated this update is google/flatbuffers#7588 Change-Id: I6bbe5d56846f426fa5f2a82c4f2bc77be2b93bb0 Signed-off-by: James Kuszmaul <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
+/-inf were not being handled, and so invalid typescript was being generated when a float/double had an infinite default value. NaN was being handled correctly. Co-authored-by: Derek Bailey <[email protected]> Co-authored-by: Casper <[email protected]>
jochenparm
pushed a commit
to jochenparm/flatbuffers
that referenced
this pull request
Oct 29, 2024
+/-inf were not being handled, and so invalid typescript was being generated when a float/double had an infinite default value. NaN was being handled correctly. Co-authored-by: Derek Bailey <[email protected]> Co-authored-by: Casper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
+/-inf were not being handled, and so invalid typescript was being generated when a float/double had an infinite default value. NaN was being handled correctly.