From bafaf77cfa9d03ebc13e06abac80c91c5e79bdf8 Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Fri, 25 Oct 2024 15:34:17 -0400 Subject: [PATCH 1/7] Update telemetry_fields.yaml Added: bypass_air_damper_voltage_command outside_air_damper_voltage_command outside_air_damper_voltage_sensor exhaust_air_damper_voltage_command exhaust_air_damper_voltage_sensor return_air_damper_voltage_command return_air_damper_voltage_sensor supply_air_damper_voltage_command supply_air_damper_voltage_sensor --- .../resources/fields/telemetry_fields.yaml | 28 +++++++++++++++++++ 1 file changed, 28 insertions(+) diff --git a/ontology/yaml/resources/fields/telemetry_fields.yaml b/ontology/yaml/resources/fields/telemetry_fields.yaml index 28b3670da..9b144977c 100644 --- a/ontology/yaml/resources/fields/telemetry_fields.yaml +++ b/ontology/yaml/resources/fields/telemetry_fields.yaml @@ -3911,3 +3911,31 @@ literals: - heating_return_water_pressure_sensor: flexible_min: -34473.78945 flexible_max: 344737.8945 +- bypass_air_damper_voltage_command: + flexible_min: 0.0 + flexible_max: 10.0 +- outside_air_damper_voltage_command: + flexible_min: 0.0 + flexible_max: 10.0 +- outside_air_damper_voltage_sensor: + flexible_min: 0.0 + flexible_max: 10.0 +- exhaust_air_damper_voltage_command: + flexible_min: 0.0 + flexible_max: 10.0 +- exhaust_air_damper_voltage_sensor: + flexible_min: 0.0 + flexible_max: 10.0 +- return_air_damper_voltage_command: + flexible_min: 0.0 + flexible_max: 10.0 +- return_air_damper_voltage_sensor: + flexible_min: 0.0 + flexible_max: 10.0 +- supply_air_damper_voltage_command: + flexible_min: 0.0 + flexible_max: 10.0 +- supply_air_damper_voltage_sensor: + flexible_min: 0.0 + flexible_max: 10.0 + From c0ef7ce730036e64a65ccc0a55b6f2589d301886 Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Fri, 25 Oct 2024 15:40:21 -0400 Subject: [PATCH 2/7] Update ABSTRACT.yaml Added ODVM: Outside Air Damper Voltage Monitoring EDVM: Exhaust Air Damper Voltage Monitoring RDVM: Return Air Damper Voltage Monitoring SDVM: Supply Air Damper Voltage Monitoring --- .../resources/HVAC/entity_types/ABSTRACT.yaml | 44 +++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml index 6e981df92..0b99f4e80 100644 --- a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml +++ b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml @@ -8649,3 +8649,47 @@ HWPM: - heating_return_water_pressure_sensor uses: - heating_supply_water_pressure_sensor + +ODVM: + guid: "9da76ec7-d839-4e6a-905c-eaedcd7796b1" + description: "Outside Air Damper Voltage Monitoring." + is_abstract: true + opt_uses: + - outside_air_damper_voltage_sensor + uses: + - outside_air_damper_voltage_command + implements: + - MONITORING + +EDVM: + guid: "7bf2a5f7-1674-4e81-85cf-98752835499b" + description: "Exhaust Air Damper Voltage Monitoring." + is_abstract: true + opt_uses: + - exhaust_air_damper_voltage_sensor + uses: + - exhaust_air_damper_voltage_command + implements: + - MONITORING + +RDVM: + guid: "00667556-8a75-46ff-a46d-b33e336fef54" + description: "Return Air Damper Voltage Monitoring." + is_abstract: true + opt_uses: + - return_air_damper_voltage_sensor + uses: + - return_air_damper_voltage_command + implements: + - MONITORING + +SDVM: + guid: "27e4aeb8-9805-41d6-879f-7e0e28d42cba" + description: "Supply Air Damper Voltage Monitoring." + is_abstract: true + opt_uses: + - supply_air_damper_voltage_sensor + uses: + - supply_air_damper_voltage_command + implements: + - MONITORING From 2e54771d1414e6448013179767c0aa0e5dbe44bd Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Fri, 25 Oct 2024 15:43:38 -0400 Subject: [PATCH 3/7] Added BYPDVM Bypass Damper Voltage Monitoring --- .../yaml/resources/HVAC/entity_types/ABSTRACT.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml index 6992ad3a5..2a4e43a1a 100644 --- a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml +++ b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml @@ -3960,6 +3960,16 @@ BYPDM: - MONITORING +BYPDVM: + guid: "c8e52e6d-1d4e-447c-ad36-044219ea89ec" + description: "Bypass damper voltage monitoring." + is_abstract: true + uses: + - bypass_air_damper_voltage_command + implements: + - MONITORING + + OAFM: guid: "4d6c951b-f9a2-445d-93d7-a8ab2aa523ad" description: "Outside air flow monitoring" From 95166723aee0db339edfc89e9fb61c7ab33e9df4 Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Thu, 31 Oct 2024 17:28:06 -0400 Subject: [PATCH 4/7] Updated max values to 120.0 --- .../resources/fields/telemetry_fields.yaml | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ontology/yaml/resources/fields/telemetry_fields.yaml b/ontology/yaml/resources/fields/telemetry_fields.yaml index 692d564e0..3d9712e23 100644 --- a/ontology/yaml/resources/fields/telemetry_fields.yaml +++ b/ontology/yaml/resources/fields/telemetry_fields.yaml @@ -3916,29 +3916,29 @@ literals: flexible_max: 344737.8945 - bypass_air_damper_voltage_command: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - outside_air_damper_voltage_command: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - outside_air_damper_voltage_sensor: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - exhaust_air_damper_voltage_command: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - exhaust_air_damper_voltage_sensor: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - return_air_damper_voltage_command: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - return_air_damper_voltage_sensor: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - supply_air_damper_voltage_command: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 - supply_air_damper_voltage_sensor: flexible_min: 0.0 - flexible_max: 10.0 + flexible_max: 120.0 From 56b7ec719d10b8a43f7c4cd3278b254470a8afc2 Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Thu, 31 Oct 2024 17:30:23 -0400 Subject: [PATCH 5/7] Made all voltage_sensors required field --- .../yaml/resources/HVAC/entity_types/ABSTRACT.yaml | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml index 2a4e43a1a..708509a89 100644 --- a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml +++ b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml @@ -8665,10 +8665,9 @@ ODVM: guid: "9da76ec7-d839-4e6a-905c-eaedcd7796b1" description: "Outside Air Damper Voltage Monitoring." is_abstract: true - opt_uses: - - outside_air_damper_voltage_sensor uses: - outside_air_damper_voltage_command + - outside_air_damper_voltage_sensor implements: - MONITORING @@ -8676,10 +8675,9 @@ EDVM: guid: "7bf2a5f7-1674-4e81-85cf-98752835499b" description: "Exhaust Air Damper Voltage Monitoring." is_abstract: true - opt_uses: - - exhaust_air_damper_voltage_sensor uses: - exhaust_air_damper_voltage_command + - exhaust_air_damper_voltage_sensor implements: - MONITORING @@ -8687,10 +8685,9 @@ RDVM: guid: "00667556-8a75-46ff-a46d-b33e336fef54" description: "Return Air Damper Voltage Monitoring." is_abstract: true - opt_uses: - - return_air_damper_voltage_sensor uses: - return_air_damper_voltage_command + - return_air_damper_voltage_sensor implements: - MONITORING @@ -8698,9 +8695,8 @@ SDVM: guid: "27e4aeb8-9805-41d6-879f-7e0e28d42cba" description: "Supply Air Damper Voltage Monitoring." is_abstract: true - opt_uses: - - supply_air_damper_voltage_sensor uses: - supply_air_damper_voltage_command + - supply_air_damper_voltage_sensor implements: - MONITORING From c760704e14d5c65f178769029be91e4bc713f67c Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Mon, 4 Nov 2024 14:17:03 -0500 Subject: [PATCH 6/7] Added bypass_air_damper_voltage_sensor --- ontology/yaml/resources/fields/telemetry_fields.yaml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ontology/yaml/resources/fields/telemetry_fields.yaml b/ontology/yaml/resources/fields/telemetry_fields.yaml index b07f0e94c..d4fe83190 100644 --- a/ontology/yaml/resources/fields/telemetry_fields.yaml +++ b/ontology/yaml/resources/fields/telemetry_fields.yaml @@ -3917,6 +3917,9 @@ literals: - bypass_air_damper_voltage_command: flexible_min: 0.0 flexible_max: 120.0 +- bypass_air_damper_voltage_sensor: + flexible_min: 0.0 + flexible_max: 120.0 - outside_air_damper_voltage_command: flexible_min: 0.0 flexible_max: 120.0 From f93909f01afb8b873de3f4dbff972a356e772076 Mon Sep 17 00:00:00 2001 From: Pranay Shah <45097539+pranay2811@users.noreply.github.com> Date: Mon, 4 Nov 2024 14:18:19 -0500 Subject: [PATCH 7/7] Added bypass_air_damper_voltage_sensor to BYPDVM --- ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml index 07909b876..19c09eea6 100644 --- a/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml +++ b/ontology/yaml/resources/HVAC/entity_types/ABSTRACT.yaml @@ -3978,6 +3978,7 @@ BYPDVM: is_abstract: true uses: - bypass_air_damper_voltage_command + - bypass_air_damper_voltage_sensor implements: - MONITORING