Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uk: Refresh translations #2490

Merged
merged 3 commits into from
Dec 6, 2024
Merged

uk: Refresh translations #2490

merged 3 commits into from
Dec 6, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Dec 3, 2024

uk: Refresh translations:

$ mdbook build
$ msgmerge --update po/uk.po book/xgettext/messages.pot

Signed-off-by: Andriy Redko <[email protected]>
Signed-off-by: Andriy Redko <[email protected]>
@reta
Copy link
Contributor Author

reta commented Dec 3, 2024

Thanks @dyeroshenko , fixed minor typo, would appreciate reapproval of workflows, sorry about that

@mgeisler
Copy link
Collaborator

mgeisler commented Dec 6, 2024

Hi @reta, I see this when I look at the diff:

% gh pr diff 2490 | bat -l patch
-#: src/SUMMARY.md src/index.md
+#: src/SUMMARY.md:3 src/index.md:1
 msgid "Welcome to Comprehensive Rust 🦀"
 msgstr "Ласкаво просимо в Comprehensive Rust 🦀"

# ...

Are you using the latest version of mdbook-i18n-helpers? With the configuration for output.xgettext in our book.toml, you should not get the line numbers (the :3 and :1 parts here).

@mgeisler
Copy link
Collaborator

mgeisler commented Dec 6, 2024

Ah, I know what the problem is!

$ MDBOOK_OUTPUT='{"xgettext": {"pot-file": "messages.pot"}}'   mdbook build -d po

This command changed — you should now just run mdbook build and then you'll find the output file as book/xgettext/messages.pot.

You should be able to fix this easily by doing a msgmerge again with book/xgettext/messages.pot.

@reta
Copy link
Contributor Author

reta commented Dec 6, 2024

You should be able to fix this easily by doing a msgmerge again with book/xgettext/messages.pot.

Ah I see, the docs are somewhat misleading in these regards, thanks for the hint!

Signed-off-by: Andriy Redko <[email protected]>
@reta
Copy link
Contributor Author

reta commented Dec 6, 2024

Should be all set, thanks a lot @mgeisler !

@mgeisler
Copy link
Collaborator

mgeisler commented Dec 6, 2024

You should be able to fix this easily by doing a msgmerge again with book/xgettext/messages.pot.

Ah I see, the docs are somewhat misleading in these regards, thanks for the hint!

I probably forgot to update the documentation somewhere, sorry about that! If you spot inconsistencies, feel free to open a PR to fix it 😄

@mgeisler mgeisler enabled auto-merge (squash) December 6, 2024 16:45
@mgeisler
Copy link
Collaborator

mgeisler commented Dec 6, 2024

Thanks for the update, this should be merged in a few minutes after the tests finish!

@mgeisler mgeisler merged commit 8f1c867 into google:main Dec 6, 2024
35 of 36 checks passed
@reta reta mentioned this pull request Dec 6, 2024
mgeisler pushed a commit that referenced this pull request Dec 9, 2024
Fix one failing test case introduced by
#2490

Signed-off-by: Andriy Redko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants