Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot search for "From and Into" #2068

Open
fw-immunant opened this issue May 9, 2024 · 4 comments
Open

Cannot search for "From and Into" #2068

fw-immunant opened this issue May 9, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@fw-immunant
Copy link
Collaborator

fw-immunant commented May 9, 2024

I think this is because the search functionality in elasticlunr ignores these in queries as "stop words". This seems like it might need fixing in upstream mdbook, but I'm not sure.

We may also want to verify that searching in non-English languages works (see rust-lang/mdBook#1081).

@mgeisler
Copy link
Collaborator

mgeisler commented Sep 7, 2024

Yeah, this is a great point and something we should look into!

@mgeisler mgeisler added bug Something isn't working good first issue Good for newcomers labels Sep 7, 2024
@mgeisler
Copy link
Collaborator

mgeisler commented Sep 7, 2024

Let me add give this the "good first issue" label so it shows up in https://github.com/google/comprehensive-rust/contribute.

@fw-immunant
Copy link
Collaborator Author

I looked into this some and because it seems to be an issue with the js implementation of the search index, I don't know if a new contributor would have a good time fixing it. I gave up after spending a couple hours.

@djmitche djmitche removed the good first issue Good for newcomers label Sep 13, 2024
@djmitche
Copy link
Collaborator

It sounds like you do know a new contrinbutor wouldn't have a good time :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants