Skip to content

Commit

Permalink
Add a dev theme to help with slide aspect ratio (#1842)
Browse files Browse the repository at this point in the history
Added a dev theme to help with slide aspect ratio while updating content
or for reviewing PRs.

Fixes #1796.

---------

Co-authored-by: Dustin J. Mitchell <[email protected]>
Co-authored-by: Martin Geisler <[email protected]>
  • Loading branch information
3 people authored Mar 5, 2024
1 parent c509dbd commit 0761f93
Show file tree
Hide file tree
Showing 6 changed files with 67 additions and 101 deletions.
4 changes: 4 additions & 0 deletions .github/workflows/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,10 @@ else
fi

mdbook build -d "$dest_dir"

# Disable the redbox button in built versions of the course
echo '// Disabled in published builds, see build.sh' > "${dest_dir}/html/theme/redbox.js"

mv "$dest_dir/pandoc/pdf/comprehensive-rust.pdf" "$dest_dir/html/"
(cd "$dest_dir/exerciser" && zip --recurse-paths ../html/comprehensive-rust-exercises.zip comprehensive-rust-exercises/)

Expand Down
11 changes: 3 additions & 8 deletions STYLE.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,9 @@ important to keep this in mind when adding content: we only have limited
vertical space. Scrolling up and down should be avoided since it is very jarring
for people who attend the class.

You can test the amount of space available using a simple tool. Uncomment these
lines in the `book.toml` file to have a red rectangle rendered on top of all
pages:

```toml
[preprocessor.aspect-ratio-helper]
command = "./aspect-ratio-helper.py"
```
You can test the amount of space available using a simple tool. This tool can be
used by clicking a toggle button next to the search button on left side of the
navbar.

The rectangle has an aspect ratio similar to what you can see when you share
your screen on a 16:9 display or projector.
Expand Down
85 changes: 0 additions & 85 deletions aspect-ratio-helper.py

This file was deleted.

10 changes: 2 additions & 8 deletions book.toml
Original file line number Diff line number Diff line change
Expand Up @@ -22,13 +22,6 @@ class = "bob"
[preprocessor.course]
verbose = false # Report timing information.

# Enable this preprocessor to overlay a large red rectangle on the
# pages. This will show you an estimate of what the course
# participants can see during the presentation.
#
# [preprocessor.aspect-ratio-helper]
# command = "./aspect-ratio-helper.py"

[output.pandoc]
optional = true
hosted-html = "https://google.github.io/comprehensive-rust/"
Expand All @@ -47,9 +40,10 @@ urlcolor = "red"

[output.html]
curly-quotes = true
additional-js = ["theme/speaker-notes.js"]
additional-js = ["theme/speaker-notes.js", "theme/redbox.js"]
additional-css = [
"theme/css/svgbob.css",
"theme/css/redbox.css",
"theme/css/speaker-notes.css",
"theme/css/language-picker.css",
"theme/css/rtl.css",
Expand Down
20 changes: 20 additions & 0 deletions theme/css/redbox.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
div#aspect-ratio-helper {
position: fixed;
top: 8px;
left: 8px;
right: 8px;
z-index: 1000;
pointer-events: none;
}

div#aspect-ratio-helper div {
outline: 3px dashed red;
margin: 0 auto;
/* At this width, the theme fonts are readable in a 16
person conference room. If the browser is wider, the
text becomes too small to be legible. */
max-width: 980px;
/* On a standard 16/9 monitor, we expect to lose a bit
of vertical space to borders. */
aspect-ratio: 16/8.5;
}
38 changes: 38 additions & 0 deletions theme/redbox.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
(function redBoxButton() {
// Create a new div element
var newDiv = document.createElement("div");
// Set the id attribute of the new div
newDiv.id = "aspect-ratio-helper";
// Create a nested div inside the new div
var nestedDiv = document.createElement("div");
// Append the nested div to the new div
newDiv.appendChild(nestedDiv, newDiv.firstChild);
// Get the parent element where you want to append the new div
var parentElement = document.body; // Change this to your desired parent element
// Append the new div to the parent element
parentElement.insertBefore(newDiv, parentElement.firstChild);
// Create the button element
var hideShowButton = document.createElement("button");
hideShowButton.innerHTML = '<i class="fa fa-square-o"></i>';
hideShowButton.className = "icon-button";
hideShowButton.type = "button";
hideShowButton.title =
"Outline the area that fits on one screen while teaching the course.";
hideShowButton.id = "Dev";
var navbarButtons = document.getElementsByClassName("left-buttons");
navbarButtons[0].insertBefore(hideShowButton, navbarButtons.firstChild);
//Default hiding the redbox
document.getElementById("aspect-ratio-helper").style.display = "none";
//Add Event listener to button to perform on click action.
hideShowButton.addEventListener("click", function () {
if (
document.getElementById("aspect-ratio-helper").style.display === "none"
) {
document.getElementById("aspect-ratio-helper").style.display = "block";
hideShowButton.innerHTML = '<i class="fa fa-square"></i>';
} else {
document.getElementById("aspect-ratio-helper").style.display = "none";
hideShowButton.innerHTML = '<i class="fa fa-square-o"></i>';
}
});
})();

0 comments on commit 0761f93

Please sign in to comment.